Hi Krishna, Fix looks good.
I suggest the following changes before committing. 1) Remove the comma in between the two bug ids. 2) Is the message “Test PASSED” required? Regards, Manajit > On 26-Feb-2018, at 10:23 PM, Semyon Sadetsky <semyon.sadet...@oracle.com> > wrote: > > +1 > > --Semyon > > > On 02/25/2018 05:53 PM, Krishna Addepalli wrote: >> Hi All, >> >> Please review a fix for JDK-8197808: >> https://bugs.openjdk.java.net/browse/JDK-8197808 >> <https://bugs.openjdk.java.net/browse/JDK-8197808> >> Webrev: http://cr.openjdk.java.net/~kaddepalli/8197808/webrev00/ >> <http://cr.openjdk.java.net/%7Ekaddepalli/8197808/webrev00/> >> >> The problem was that by the time Robot tries to read the color on screen, >> the compositing of the window is not completed, and hence, instead of >> reading Blue color, it is reading a combination of Blue and Red colors. >> Increasing the delay by 100 ms made sure that the composition is complete >> and the color is being read correctly. Also, this happens only on Windows 10. >> Apart from this, the test was not cleaning up the windows when it throws >> exception, so fixed that, and also added all explicit imports. >> >> Thanks, >> Krishna > >
