Hi Sergey, Before I sent out this review I ran this test different platforms and saw that it was passing. But then after I sent it out for review I found that the test had not run on Windows 10!! That was strange and was not expecting it in the first place. I found that mouseMoved() event was never received for the frame 2!! And our test passes or fails within the frame 2's mouseMoved() event callback.
We do receive this event on mac and win 7 and am not sure why are we missing it on win 10. So I think it is good to make this test specific to mac as the original fix was specific to mac only and log a new bug to debug on this problem. I do not see as an issue with test as it is a simple test and it falsely passes even with normal dpi and hidpi on win 10. And bug JDK-8027154 was a test only update. Thanks and regards, Shashi -----Original Message----- From: Sergey Bylokhov Sent: Tuesday, February 27, 2018 4:05 AM To: Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com>; awt-dev@openjdk.java.net Subject: Re: <AWT Dev> [11] JDK-8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails Hi, Shashi. Why this test should be platform specific? It shows two common frames and use some generic api for mouse events. This test also was updated in JDK-8027154 and I assume it should works on macOS after that, maybe we have a new regression here? On 24/02/2018 07:32, Shashidhara Veerabhadraiah wrote: > Hi All, Please review a test fix for the below bug: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196017 > > Webrev: > http://cr.openjdk.java.net/~sveerabhadra/8196017/webrev.00/ > > Summary: The original bug > https://bugs.openjdk.java.net/browse/JDK-8012026 fixed the code only > for MacOS platform but the test is enabled to run on all platforms. > This is modified. Along with it exact positional comparison was done > in the test and now modified to allow for leniency of around 2 pixels. > > Thanks and regards, > Shashi > -- Best regards, Sergey.
