Hi Anton, The fix looks good, but I wonder if we also shall check results of isDisplayable() and isVisible() before showing touch keyboard. My assumption is the following: we cannot transfer focus to non-displayable or invisible components, so it is unnecessary to display touch keyboard for such components too.
Thanks, Dmitry > On 1 Mar 2018, at 16:30, anton.litvi...@oracle.com wrote: > > Hello, > > Could you please review the following fix for the bug. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8198605 > Webrev: http://cr.openjdk.java.net/~alitvinov/8198605/jdk11/webrev.00 > > The fix extends a number of the required conditions in the method > "sun.awt.windows.WToolkit.showOrHideTouchKeyboard(Component, AWTEvent)", > which should be satisfied for showing of the touch keyboard, by checking if > the component is focusable or not. > > Thank you, > Anton
