Hi Sergey,

Please review the updated patch:
http://cr.openjdk.java.net/~pkbalakr/8196435/webrev.02/ 

Regards,
Prem

-----Original Message-----
From: Sergey Bylokhov 
Sent: Monday, March 05, 2018 10:27 PM
To: Prem Balakrishnan <prem.balakrish...@oracle.com>; awt-dev@openjdk.java.net
Subject: Re: <AWT Dev> [11] Review Request: JDK-8196435 Regression automated 
Test 'java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java' 
fails

On 01/03/2018 20:16, Prem Balakrishnan wrote:
> The existing waitForIdle() call at line 55 is called after calling 
> setVisible() for both the frames (which I have removed in proposed fix). I 
> have added waitForIdle() call after calling setVisible() for each frame(at 
> line 103 and 110 in proposed fix), which ensures frontFrame is rendered on 
> top of backFrame.

I doubt that this will fix the problem - it will decrease the possibility of 
such behavior.
Please add toBack()/toFront calls for these frames to make a correct order.

> 
> Regards,
> Prem
> 
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: Friday, March 02, 2018 3:19 AM
> To: Prem Balakrishnan <prem.balakrish...@oracle.com>; 
> awt-dev@openjdk.java.net
> Subject: Re: <AWT Dev> [11] Review Request: JDK-8196435 Regression 
> automated Test 
> 'java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java' 
> fails
> 
> Hi, Prem.
> On 26/02/2018 21:20, Prem Balakrishnan wrote:
>> At times backFrame is rendered on top of frontFrame, due to which mouse 
>> position on backFrame is not NULL and test fails, solved this by adding 
>> waitForIdle() calls appropriately. Furthermore, mousemove from frontFrame to 
>> backFrame, caused the cursor to change to resize cursor and test fails, 
>> solved this by setting setResizable() to false.
> 
> But the old version of the test also call Util.waitForIdle(null) after frames 
> were shown at line 55.
> 
> 


--
Best regards, Sergey.

Reply via email to