Hi Anton, The fix looks good.
Thanks, Dmitry > On 12 Mar 2018, at 13:24, Anton Litvinov <[email protected]> wrote: > > Hello, > > Could you please review the following fix for the bug. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8198606 > Webrev: http://cr.openjdk.java.net/~alitvinov/8198606/jdk11/webrev.00 > > The root cause of the bug is the fact that starting from one of the last > updates of MS Windows 10 the window of the touch keyboard does not have the > style "WS_VISIBLE", even when it is really visible, and the method > "AwtToolkit::HideTouchKeyboard()" does not execute the code hiding the touch > keyboard, because the method "AwtToolkit::GetTouchKeyboardWindow()" return > "NULL", since one of its conditions, particularly "::IsWindowVisible(hwnd)", > where "hwnd" is a handle of the touch keyboard window, currently always > returns "FALSE". > > The fix for this bug removes this extra "if" condition from the method > "AwtToolkit::GetTouchKeyboardWindow()", which in current circumstances is > always evaluated as "FALSE". > > Thank you, > Anton
