Hi, I am not to understand why ScrollPane.cpp was changed ? And why cpp files?
Cheers 2018-03-19 6:25 GMT+01:00 Dipak Kumar <[email protected]>: > Hi Patrick, > > > > File “awt_ScrollPane.cpp” has already been reviewed as part of JDK 11. The > only difference between JDK 11 changeset and JDK 8 backport is the test > file (ScrollPaneValidateTest.java), not awt_ScrollPane.cpp. > > I had mentioned that in my previous mail. > > > > If at all there is any concern related awt_ScrollPane.cpp file then I > think that should be dealt after filing another issue. > > > > Moreover I didn't really get your question. Out of two nested if blocks, > one has been removed and yes, variables are being used and their > declarations are still intact. > > > > Please let me know if you need any more info. > > > > Thanks, > > Dipak > > > > *From:* Patrick Chen [mailto:[email protected]] > *Sent:* 14 March 2018 18:21 > *To:* Dipak Kumar <[email protected]> > *Cc:* [email protected] > *Subject:* Re: <AWT Dev> [8u-backport] Review request for 8195738 : > scroll poistion in ScrollPane is reset after calling validate() > > > > Hi, > > Why in src/windows/native/sun/windows/awt_ScrollPane.cpp did you delete > the main condition? > > Means : the two variables are used isn't it ? > > > > Cheers, > > Pc > > > > 2018-03-14 11:02 GMT+01:00 Dipak Kumar <[email protected]>: > > Hi All, > > > > Please review the below patch (for 8u-backport) - > > > > Webrev : http://cr.openjdk.java.net/~dkumar/8195738/webrev.00/ > > JBS : https://bugs.openjdk.java.net/browse/JDK-8195738 > > JDK 11 changeset - http://hg.openjdk.java.net/jdk/client/rev/96bebffe0be1 > > > > Patch pushed for JDK 11 applies cleanly to JDK 8 after adjusting file path > except 'headful' keyword has been removed from the test as this is not > defined for 8. > > Related Jtreg tests have been run against the proposed patch and results > are fine. > > > > Thanks, > > Dipak > > > > >
