Looks fine.

On 05/04/2018 15:39, Alexey Ivanov wrote:

Could you please review the fix for jdk11?

bug: https://bugs.openjdk.java.net/browse/JDK-8199627
webrev: http://cr.openjdk.java.net/~aivanov/8199627/webrev.0/

Windows 10 v1703 provides improved High DPI mode: Per-Monitor v2. [1]

Java already supports "Per-Monitor v1" mode. This change extends High DPI support in Java: in addition to <dpiAware> element [2], a new <dpiAwareness> element [3] is added to Java launcher manifest. The element <dpiAwareness> is recognized by Windows 10 v1607 and above, PerMonitorV2 value is supported by Windows 10 v1703 and above.

The most notable change for Java applications is that window title bar is scaled correctly when application window moves from one monitor to another or the scaling changes.

When building, manifest tool generates warning for unknown <dpiAwareness> element in manifest. It is because an older Windows SDK is used to build JDK which does not know about an element that was added later. The build succeeds despite the warning.

Thank you in advance.


[1] https://msdn.microsoft.com/library/windows/desktop/mt843498(v=vs.85).aspx#Per-Monitor_and_Per-Monitor__V2__DPI_Awareness_ <https://msdn.microsoft.com/library/windows/desktop/mt843498%28v=vs.85%29.aspx#Per-Monitor_and_Per-Monitor__V2__DPI_Awareness_> [2] https://msdn.microsoft.com/en-us/library/windows/desktop/aa374191(v=vs.85).aspx#dpiAware <https://msdn.microsoft.com/en-us/library/windows/desktop/aa374191%28v=vs.85%29.aspx#dpiAware> [3] https://msdn.microsoft.com/en-us/library/windows/desktop/aa374191(v=vs.85).aspx#dpiAwareness <https://msdn.microsoft.com/en-us/library/windows/desktop/aa374191%28v=vs.85%29.aspx#dpiAwareness>

Best regards, Sergey.

Reply via email to