Hi Prem, The changes looks fine to me. Thanks and regards, Shashi
-----Original Message----- From: Sergey Bylokhov Sent: Friday, May 11, 2018 2:25 AM To: Prem Balakrishnan <prem.balakrish...@oracle.com>; awt-dev@openjdk.java.net Subject: Re: <AWT Dev> [11] Review Request JDK-8196360 java/awt/Dialog/SiblingChildOrder/SiblingChildOrderTest.java fails Hi, Prem. The changes are fine, but you need to remove this test from the problemList. On 10/05/2018 02:37, Prem Balakrishnan wrote: > Hi Sergey, > >>> Slight variation in the RGB value caused the test to fail on OS X >>10.12.6 >>> and On OS X 10.13.1 test passes always. > > I am not able to reproduce this issue(slight variation in RGB Value) on OSX > 10.12.6.Executed several times. > Please review updated patch, which solves Windows 10 related issue. > Webrev: http://cr.openjdk.java.net/~pkbalakr/8196360/webrev01/ > > Regards, > Prem > > -----Original Message----- > From: Sergey Bylokhov > Sent: Tuesday, May 08, 2018 12:54 AM > To: Prem Balakrishnan <prem.balakrish...@oracle.com>; > awt-dev@openjdk.java.net > Subject: Re: <AWT Dev> [11] Review Request JDK-8196360 > java/awt/Dialog/SiblingChildOrder/SiblingChildOrderTest.java fails > > Hi, Prem. > Did you check why the rong value is returned by the Robot? Maybe some of > "window decoration" are different in osx 10.12(shadows/title/etc)? > > On 07/05/2018 02:33, Prem Balakrishnan wrote: >> Please review fix for JDK 11: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8196360 >> >> Webrev: http://cr.openjdk.java.net/~pkbalakr/8196360/webrev00/ >> >> On Mac , slight variation in the RGB value caused the test to fail >> only on OS X 10.12.6 ( On OS X 10.13.1 test passes always). > > > > > -- > Best regards, Sergey. > -- Best regards, Sergey.
