Hi Manajit,

The current implementation assumes that orderAboveSiblings() places the window 
in front of other windows located at the same level. The proposed fix 
introduces new behaviour: if the window does not have an owner and child 
windows it won’t be ordered, (i.e. in certain conditions the window may be 
obscured by other windows even after orderAboveSibling() execution). Most 
likely such approach will break existed functionality - some windows will be 
incorrectly placed behind other windows.

I am sorry, but the relationship between the original problem described in the 
bug, (i.e. cycling through windows issue) and implementation of 
orderAboveSiblings() is NOT clear. Can you explain this?

Thanks,
Dmitry  

> On 31 Aug 2018, at 07:55, Manajit Halder <manajit.hal...@oracle.com> wrote:
> 
> Hi All,
> 
> Please review the fix for JDK12.
> 
> 
> 
> Bug: 
>      https://bugs.openjdk.java.net/browse/JDK-8206392 
> <https://bugs.openjdk.java.net/browse/JDK-8206392>
>  <https://bugs.openjdk.java.net/browse/JDK-8206392>
> Webrev: 
> 
>     http://cr.openjdk.java.net/~mhalder/8206392/webrev.00/ 
> <http://cr.openjdk.java.net/%7Emhalder/8206392/webrev.00/>
> Fix: 
> 
>     Window ordering is not required if the window doesn't own any other 
> windows.
> 
> Regards,
> Manajit

Reply via email to