Looks fine.
On 16/10/2018 16:19, Alan Snyder wrote:
Hi Sergey,
Thank you for your review.
I agree that the solution you describe is safer in the long run.
The client may need to wait for a resize event to be sure that the change has
taken effect.
The updated webrev: http://cr.openjdk.java.net/~alans/8211301/webrev.01/
CSR: https://bugs.openjdk.java.net/browse/JDK-8212549
Regards,
Alan
On Oct 16, 2018, at 12:32 PM, Sergey Bylokhov <sergey.bylok...@oracle.com
<mailto:sergey.bylok...@oracle.com>> wrote:
Hi, Alan.
The fix in general looks fine, note that you will need create a CSR for the new
properties.
I have a questions about the changes in AWTWindow.nativeSetNSWindowStyleBits()
- Note that after the fix it will block the current thread, this might cause a
deadlock if some code on Appkit will try to access resources blocked by the
current thread.
- The new code below is executed on the current thread, and actually may be
executed in parallel with the same code in _deliverMoveResizeEvent() on Appkit:
1115 if (resized) {
1116 [AWTToolkit eventCountPlusPlus];
1117 NSRect frame = ConvertNSScreenRect(env, resizeFrame);
1118 deliverMoveResizeEvent(env, frame, javaPlatformWindow, NO);
1119 [AWTWindow synthesizeMouseEnteredExitedEventsForAllWindows];
1120 }
- Note that [AWTWindow synthesizeMouseEnteredExitedEventsForAllWindows] will
access cocoa components and should be use on Appkit.
I think that you can move this new code to the block above and drop shouldWait.
On 11/10/2018 09:03, Alan Snyder wrote:
A reminder...
Please review the following change to the macOS AWT:
Bug: https://bugs.openjdk.java.net/browse/JDK-8211301
Revision: http://cr.openjdk.java.net/~alans/8211301/webrev.00/
This change allows applications on macOS to configure windows to use the full
window content view option and the transparent title bar option.
If approved, I will need a sponsor…
Thank you.
Alan
--
Best regards, Sergey.
--
Best regards, Sergey.
