Hi Krishna, Thanks for your review. That was really a good observation and as you rightly said, some visual cue needs to be there around the progress bar, else it does look lost.
Thanks and regards, Shashi -----Original Message----- From: Krishna Addepalli Sent: Tuesday, October 23, 2018 1:54 PM To: Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com> Cc: awt-dev@openjdk.java.net; swing-...@openjdk.java.net Subject: Re: <Swing Dev> [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar Hi Shashi, The fix looks good to me. Regarding the decision of placing the line “setFocusable(true)” in the constructor of ProgressBar, I think that is a good decision since the Swing users needn’t explicitly make that call to make it accessible. There is one problem though: The focus is not shown on the progress bar, and at that point, it feels like the focus is lost and may lead to some confusion. I think it would be good if we can render a focus rect around the progress bar to let users know that it is in focus, which ofcourse can be addressed separately. Thanks, Krishna > On 22-Oct-2018, at 1:06 PM, shashidhara.veerabhadra...@oracle.com wrote: > > Hi All, Please review a swingset fix for the below bug. > > Bug: https://bugs.openjdk.java.net/browse/JDK-7124285 > > Fix: http://cr.openjdk.java.net/~sveerabhadra/7124285/webrev.00/ > > Problem: The JProgressBar component used in the swingset demo was not > focusable and once it is turned on, now the progress status is getting > narrated via the voice over. > > Thanks and regards, > Shashi >
