Yes, I think we now have a good understanding of why this hangs. The remaining discussion, in my opinion, is if we should block or not while handling SequencedEvents. I'd like to see strong arguments on both sides to get this right. Even though my original position was for not-blocking -for the reasons already shared-, I acknowledge that a deeper investigation is needed and will do it as soon as possible.
On Thu, Oct 25, 2018 at 11:40 AM, Mario Torre <neug...@redhat.com> wrote: > I'm not a reviewer, but FWIW I concur with the analysis and with the > proposed solution. > > Cheers, > Mario > On Thu, Oct 25, 2018 at 10:05 AM Laurent Bourgès > <bourges.laur...@gmail.com> wrote: > > > > Hi Sergey & Martin, > > > >> > >> > AWT experts, what do you advice about asynchronous events: to Block > or to dispatch selected awt events... > >> > >> I think that before answer this question we need to clarify why the > current code hangs. > > > > > > According to me, Martin already exposed his detailled analysis of 2 > cases making AWT to hang with several AppContexts: in summary, like a > deadlock, the EDT threads are waiting for each other to dispatch > SequencedEvents ! > > > > Please Martin correct me, or maybe give us an updated diagnostic of the > problem ? > > > > This thread is already quite long and both Martin & me invested a lot of > time on debugging, fixing & testing, please give us your understanding, > Sergey. > > > > Finally I am in favor of Martin's patch 2 sent by Oct 16th: > > http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.02 > > > > Cheers, > > Laurent > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH <https://www.redhat.com> > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >
