Hi Sergey, The changes looks good to me. Thanks and regards, Shashi
-----Original Message----- From: Sergey Bylokhov Sent: Tuesday, October 30, 2018 6:28 AM To: Krishna Addepalli <krishna.addepa...@oracle.com>; awt-dev@openjdk.java.net Subject: Re: <AWT Dev> [12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints stacktrace to stderr. Hi, Krishna. Thank you for review! Any volunteers for the second +1? =) On 07/10/2018 22:02, Krishna Addepalli wrote: > +1 > > Thanks, > Krishna > > -----Original Message----- > From: Sergey Bylokhov > Sent: Monday, October 8, 2018 10:26 AM > To: awt-dev@openjdk.java.net > Subject: <AWT Dev> [12] Review Request: 8210231 Robot.delay() catches > InterruptedException and prints stacktrace to stderr. > > Hello. > Please review the fix for jdk12. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8210231 > Webrev: http://cr.openjdk.java.net/~serb/8210231/webrev.00 > > The Robot.delay() is a simple wrapper on top of Thread.sleep(), which ignores > the InterruptedException. But in case of InterruptedException it prints the > stack trace, which is unspecified behavior. > > In the fix the "printStackTrace()" was removed, and the interrupted state of > the thread is restored. > -- Best regards, Sergey.
