On 11/2/2018 1:08 PM, Sergey Bylokhov wrote:
Hi, Phil.
On 02/11/2018 12:50, Phil Race wrote:
As well as building I ran all our automated tests on Ubuntu which
makes a lot of
use of the Robot API. So I am reasonably confident this all works as
before.
We do still have failures due to unstable tests, but the ones I saw I
was able to
reproduce without these changes.
I guess you completed the tests using awt.robot.gtk=false property?
Otherwise implementation based on gtk was used.
Good point. Let me re-run them with that property :-)
Results on Monday since they take a while to run.
Of course since we don't run that option usually, if I find more
failures I'll then
have to verify whether it is pre-existing with the old code.
FYI to others .. I experimented a while back with making gtk the only option
and it worked on our platforms but some platforms do not have gtk so we
need to keep the fall back for now.
But please take a look at the changes, esp. in multVis.c whilst I do this ..
-phil.
And there's no new regression test since we have that coverage and this
is just implementation.
-phil.
