Hi Volker, looks good to me. Lets wait for jdk-submit though - especially since you changed linking on Windows too by adding JNIEXPORT.
Gruss Thomas On Tue, Nov 20, 2018 at 6:13 PM Volker Simonis <volker.simo...@gmail.com> wrote: > > Hi, > > so here's a reworked version of my previous change: > > http://cr.openjdk.java.net/~simonis/webrevs/2018/8214120/ > https://bugs.openjdk.java.net/browse/JDK-8214120 > > In addition to my initial change (which unfortunately broke the > Solaris build) the new version has to JNIEXPORT the following methods > from libawt.so otherwise they won't be visible in libawt_xawt.so on > some platforms which make symbols local by default (e.g. Solaris): > > DAssert_Impl > DTrace_PrintFunction > DTrace_VPrint > DTrace_VPrintln > > Local tests on Linux/AIX and Solaris succeeded. The patch is currently > building in the submit repo. > > Thank you and best regards, > Volker
