Hello.
Could you review the fix again ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8212676
Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.01/
I applied following changes:
* I added AIX detection code into sun.awt.OSInfo class.
It seems CDE's default should be middle color.
But AIX's default is high color, so AIX detection code is required.
* MWM detection code can be used on Linux and AIX platform
AIX only code was removed
* I could not recreate XMapRaised/XMapWindow related issue.
The fix was ignored
* Non-focusable window handling on DTWM/MWM
I checked Linux's MWM working behavior on RHEL6.
I applied AIX's code into Linux side, but it was bad.
Working behavior became worse.
So AIX detection feature is still required.
(JDK-8212676 was also updated)
I'd like to obtain a sponsor for this issue.
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2018-12-05 18:22, Ichiroh Takiguchi wrote:
Hello Phil.
I heard some of AIX users used RealVNC VNC Enterprise Edition for AIX
maintenance. [1]
I assume they still use CDE.
[1] https://www.realvnc.com/en/connect/download/vnc/aix/#older-versions
Thanks,
Ichiroh Takiguchi
On 2018-12-05 15:44, Philip Race wrote:
. and I think I need to be convinced about whether "aix" is the right
thing to check here.
"I know AIX works like this today" isn't a very robust, or very
portable approach.
The fix is more about the CDE/Motif environment than AIX, isn't it ?
-phil.
On 12/4/18, 5:11 PM, Philip Race wrote:
On 12/4/18, 5:10 PM, Ichiroh Takiguchi wrote:
Hello Phil.
I haven't evaluated the merits of this proposal but this
https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/src/java.desktop/share/classes/sun/font/FontUtilities.java.udiff.html
is not the right place to support a flag used in all these X11
files.
Could you give me your recommendation ?
Somewhere closer to the code that needs it.
And why is i18n-dev on the review ? I can't see any I18N related
changes.
I thought focus issue was related input method.
No. I mean input focus is necessary for input methods but focus does
not
automatically mean input methods are in play.
-phil
AIX IM was activated even if focus was moved to non focusable window
(middle window). [1]
So I posted this issue into I18N, but it was not good.
Actually, all key events were forwarded to middle window if user
clicked inside of right window.
[1]
https://bugs.openjdk.java.net/secure/attachment/79986/aix-focusable.png
Thanks,
Ichiroh Takiguchi
On 2018-12-05 03:06, Phil Race wrote:
I haven't evaluated the merits of this proposal but this
https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/src/java.desktop/share/classes/sun/font/FontUtilities.java.udiff.html
is not the right place to support a flag used in all these X11
files.
And why is i18n-dev on the review ? I can't see any I18N related
changes.
-phil.
On 12/4/18 8:53 AM, Ichiroh Takiguchi wrote:
Hello again.
Could you give me review comment and/or suggestion ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8212676
Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/
Thanks,
Ichiroh Takiguchi
On 2018-11-26 21:27, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8212676
Change:
https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/
Test instructions and screen shots are in JDK-8212676.
GUI environment for AIX platform still needs CDE support.
This fix is required to avoid unexpected working behavior on AIX
platform.
I'd like to obtain a sponsor for this issue.
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2018-06-18 18:57, Ichiroh Takiguchi wrote:
Hello.
This fix is really required for AIX's GUI.
System color setting and window manager's working behavior are
very important.
I appreciate any feedback, and how I would go about obtaining a
sponsor and contributor ?
On 2018-05-25 11:02, Ichiroh Takiguchi wrote:
Hello Phil.
webrev file was extracted.
Please see
http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev.00/
On 2018-05-19 02:48, Ichiroh Takiguchi wrote:
Hello Phil.
Webrev.zip file is stored into
http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev-aixgui.zip
Test programs are also stored:
No testcase is available for FontUtilities.java and
XDecoratedPeer.java.
MotifColorUtilities.java
http://cr.openjdk.java.net/~aleonard/AIX_GUI/SystemColorTest2.java
Run SystemColorTest2, system colors should be displayed
AIX sample is
http://cr.openjdk.java.net/~aleonard/AIX_GUI/aix_systemcolor.txt
XWM.java
http://cr.openjdk.java.net/~aleonard/AIX_GUI/XWMTest1.java
On AIX CDE, isMotif and isCDE were true.
On AIX MWM, every entry is false.
XWindowPeer.java
http://cr.openjdk.java.net/~aleonard/AIX_GUI/JFrameTest.java
On AIX CDE, click inside of "Non-Focusable" window (not window
frame).
Window focus should not be changed because of "click on focus"
feature.
But input focus is moved to "Non-Focusable" window.
On 2018-05-18 01:00, Phil Race wrote:
I think we'd need to see the actual proposed changes and
understand
the implications
for ongoing support as we no longer support any platform
which has a
CDE desktop.
Solaris 11.3 uses Gnome, so we'd be more inclined to be
ripping out
such support rather
than adding to it.
-phil.
On 05/17/2018 04:18 AM, Ichiroh Takiguchi wrote:
Hello,
IBM would like to contribute AIX's CDE (Common Desktop
Environment) DTWM (Desktop Window Manager) /MWM (Motif
Window Manager) support to OpenJDK project.
I'd like contribute following 5 files:
M src/java.desktop/share/classes/sun/font/FontUtilities.java
(Add isAIX flag to determine AIX platform for GUI
environment)
M
src/java.desktop/unix/classes/sun/awt/X11/MotifColorUtilities.java
(Add High Color support on CDE, OpenJDK just supports Medium
Color) [1]
M
src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java
(Avoid miss calculation for window position under DTWM/MWM
by XMapRaised/XMapWindow)
M src/java.desktop/unix/classes/sun/awt/X11/XWM.java
(Detect MWM on AIX platform)
M src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java
(Add non-focusable window support on DTWM/MWM for AIX,
because DTWM/MWM does not have enough features for ICCCM)
I appreciate any feedback please, and how I would go about
obtaining a sponsor and contributor ?
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
[1]
https://docs.oracle.com/cd/E19253-01/806-7492/fontsandcolors-15233/index.html
