On 20/03/2019 15:45, Philip Race wrote:
Except for the legal header, I think your "patches" should be
inside a platform ifdef to show exactly where they are needed
and also be bracketed by comments
Note that this patch is not visible in the main webrev, because it is not
"my patch", it is already in our repo. I just highlighted it.
It could be build using custom unistd.h or unistd.h from the cygwin/mingw.
So something like this :
/** Begin JDK modifications to support building on Solaris **/
#ifdef SOLARIS
..
#endif /* SOLARIS */
/** End JDK modifications to support building on Solaris **/
Will update the patch.
-phil.
On 3/20/19, 3:28 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for JDK 13.
Bug: https://bugs.openjdk.java.net/browse/JDK-8220495
Fix: http://cr.openjdk.java.net/~serb/8220495/webrev.02
The giflib was updated from 5.1.4 to 5.1.8.
The is mostly a replacement of old files(5.1.4) by the new files(5.1.8) except
two additional steps.
- The library uses "<unistd.h>" which breaks the build on windows, and
"<stdbool.h>" wihch does not work properly on old Solaris.
It was fixed by this patch(same as in 5.1.4 during previous upgrade):
http://cr.openjdk.java.net/~serb/8220495/giflib
- I have drop the usage of "tabs" and manually reformat the code to make the
diff smaller.
Mach5 on all platforms is green.
--
Best regards, Sergey.
