Hi Alexey,
On Tue, Mar 26, 2019 at 2:36 PM Alexey Ivanov <alexey.iva...@oracle.com> wrote: > Hi Thomas, > > Looks good, I'm not a reviewer though. > Could I also ask you to push this changeset to jdk/client [1] instead of > jdk/jdk? > > A small question: two prototypes are changed in debug_trace.h but only > one is updated in debug_trace.c. Is it because the functions matching > the second prototype have already been updated with JNICALL? > > Not really sure I understand the question. There is no real 1:1 relationship between my change in .h and .c: DTRACE_PRINTxx macros call _DTrace_Template() which expands to DTrace_PrintFunction(). First argument is pointer to DTrace_VPrint(), which is a function decorated with JNICALL. Hence the build error - the type of the first argument of DTrace_PrintFunction is DTRACE_PRINT_CALLBACK, which is a fkt pointer *without* JNICALL. So one way to fix this was to correct the DTRACE_PRINT_CALLBACK type to be a fkt pointer pointing to a JNICALL decorated function. That means that I also needed to fix all functions whose pointers are being passed around as DTRACE_PRINT_CALLBACK. But there only was one I saw, DTrace_PrintStdErr(). I'll push to jdk/client. Will that be transported to jdk/jdk automatically? Cheers, Thomas > Regards, > Alexey > > [1] http://hg.openjdk.java.net/jdk/client/ > > On 25/03/2019 13:09, Thomas Stüfe wrote: > > Hi all, > > > > Issue: https://bugs.openjdk.java.net/browse/JDK-8221405 > > cr: > > > http://cr.openjdk.java.net/~stuefe/webrevs/8221405-windows32-awt-buildfixes/webrev.00/webrev/ > > > > On 32bit windows, awt build did bitrot. Dtrace print callbacks need to > > be declared with __stdcall. No other platform cares. > > > > Thanks, Thomas > >
