Looks OK.

-phil.

On 4/21/19 11:48 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for JDK 13.

Bug: https://bugs.openjdk.java.net/browse/JDK-8222789
Fix: http://cr.openjdk.java.net/~serb/8222789/webrev.00

Currently, AWT on Solaris uses "Sun's Xinerama API" which is non-standard API implemented in the libXext, we use it from 2001, but the standard version of "Xinerama API" was added Solaris in nv_62: https://blogs.oracle.com/solaris/x11-apis-for-querying-multi-head-screen-layout-v2

I have checked that libXinerama.so.1 library exists on Solaris 11 Sparc and x64.

I was able to prove that Java2D reports the correct number of the screens(the same as before the fix):
 - in Solaris Sparc when the X redirected to the dual-head Linux
 - in Solaris x64 in a VirtualBox when two screens are emulated

After the fix we will use the same code for Linux/Solaris/AIX.


Reply via email to