+1

Thanks,
Jay

-----Original Message-----
From: Prasanta Sadhukhan 
Sent: Tuesday, May 28, 2019 4:19 PM
To: Jayathirth D V; awt-dev@openjdk.java.net
Subject: Re: <AWT Dev> [13] RFR JDK-8224821: 
java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java
 fails linux-x64

Thanks Jay for review. I added it for safety but it seems it is not needed, 
only the 2nd one is needed. Test still pass with only the 2nd one...So, 
modified webrev

http://cr.openjdk.java.net/~psadhukhan/8224821/webrev.1/

Regards
Prasanta
On 28-May-19 3:30 PM, Jayathirth D V wrote:
> Hi Prasanta,
>
> We are already waiting for 2 secs in Util.focusComponent(), do we need the 
> first delay of 2 secs just before that?
> Second robot.delay() is okay.
>
> Thanks,
> Jay
>
> -----Original Message-----
> From: Prasanta Sadhukhan
> Sent: Tuesday, May 28, 2019 2:47 PM
> To: awt-dev@openjdk.java.net
> Subject: Re: <AWT Dev> [13] RFR JDK-8224821: 
> java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabl
> edCompTest.java fails linux-x64
>
> PS: Modified test pass on windows,linux headful mach5 systems, on mac it is 
> problemlisted already.
>
> Regards
> Prasanta
>
> On 27-May-19 2:39 PM, Prasanta Sadhukhan wrote:
>> Hi All,
>>
>> Please review a test fix for an issue where it seems focus does not 
>> transfer automatically in some case in our headful nightly system.
>> Issue seems to be due to test expects focus to be shifted too soon 
>> which may not happen like that in somewhat slow system. So, added 
>> some delay which makes the test pass in the mach5 system
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224821
>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224821/webrev.0/
>>
>> Regards
>> Prasanta

Reply via email to