Seems fine to me.
-phil.
On 6/11/19, 2:20 PM, Sergey Bylokhov wrote:
I guess the better solution is to use PlatformLogger, like this:
http://cr.openjdk.java.net/~serb/8221246/webrev.02
Any thoughts?
On 11/06/2019 05:29, Sergey Bylokhov wrote:
Hello.
I would like to discuss the possible fix for JDK 13.
Bug: https://bugs.openjdk.java.net/browse/JDK-8221246
Fix: http://cr.openjdk.java.net/~serb/8221246/webrev.01
The user complains that in a few places we swallow the exceptions,
and because of that he gets some other exceptions.
The problem is that we expose this API via FileSystemView, where
different methods lack any exceptions. As a result, we have a
suggestion to print the stack-traces in case of errors like
IOException and InterruptedException. Note that we cannot do this for
SecurityException because the path which we check is not passed by
the user, so he do not know it.
There are some other places where we skip exceptions, like:
http://hg.openjdk.java.net/jdk/client/file/f85fa2fc78c2/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java#l317
But it looks like we never return null there.
