Looks like in case of JavaAccessBridge we were closing log file but it was 
missed for WindowsAccessBridge.
Changes are fine.

Thanks,
Jay 

> On 10-Sep-2019, at 3:36 PM, Pankaj Bansal <pankaj.b.ban...@oracle.com> wrote:
> 
> Hi All,
> 
> Please review the following fix for jdk14.
> 
> Bug: 
> https://bugs.openjdk.java.net/browse/JDK-8225805 
> <https://bugs.openjdk.java.net/browse/JDK-8225805>
>  
> webrev
> http://cr.openjdk.java.net/~pbansal/8225805/webrev01/ 
> <http://cr.openjdk.java.net/~pbansal/8225805/webrev01/>
>  
>  
> Issue:
> The Windows WindowsAccessBridge Log file is not being closed anywhere. We 
> should always close opened resources.
> It is not causing any issue as all files opened by the program are closed 
> when program exits normally (JAWS in this case). But case be an issue in case 
> the program terminates abnormally. We should explicitly close the log file.
>  
> Fix:
> Closed the WindowsAccessBridge log file in destructor.
>  
> 
> Regards,
> Pankaj Bansal

Reply via email to