Looks good.
-phil.
On 9/12/19, 11:37 PM, Baesken, Matthias wrote:
Hi Christoph,
I removed the blanks after ReleaseStringUTFChars in fontpath.c,
and adjusted the ReleaseStringUTFChars call to C++ syntax in
ShellFolder2.c.
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8230900.1/
<http://cr.openjdk.java.net/%7Embaesken/webrevs/8230900.1/>
Best Regards ,
Matthias
*From:*Langer, Christoph <christoph.lan...@sap.com>
*Sent:* Donnerstag, 12. September 2019 21:29
*To:* Baesken, Matthias <matthias.baes...@sap.com>;
2d-...@openjdk.java.net; awt-dev@openjdk.java.net
*Subject:* RE: RFR [XS] : 8230900: missing ReleaseStringUTFChars in
java.desktop native code
Hi Matthias,
the changes seem to make sense.
I've got 2 findings:
In fontpath.c, there is a space between ReleaseStringUTFChars and (
which should be removed in lines 1282 and 1339.
In ShellFolder2.c, line 1134, the function call takes only 2
parameters. You need to remove the first param env. Otherwise it
breaks the Windows build.
Thanks
Christoph
*From:*2d-dev <2d-dev-boun...@openjdk.java.net
<mailto:2d-dev-boun...@openjdk.java.net>> *On Behalf Of *Baesken, Matthias
*Sent:* Donnerstag, 12. September 2019 11:08
*To:* 2d-...@openjdk.java.net <mailto:2d-...@openjdk.java.net>;
awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>
*Subject:* [CAUTION] [OpenJDK 2D-Dev] RFR [XS] : 8230900: missing
ReleaseStringUTFChars in java.desktop native code
Hello, please reviews this small fix .
It adds a couple of missing ReleaseStringUTFChars calls in
java.desktop module native coding (mostly in cases of early returns).
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8230900
http://cr.openjdk.java.net/~mbaesken/webrevs/8230900.0/
<http://cr.openjdk.java.net/%7Embaesken/webrevs/8230900.0/>
Thanks, Matthias
