Hi, Dmitry.
It is interesting that previously this bug was fixed loooong time ago:
https://bugs.openjdk.java.net/browse/JDK-4392080
Looks like the evaluation of that bug is the same as the current one, right?
Can we report this bug upstream, and provide the patch with a proper
description of the bug?
On 9/19/19 11:25 am, Dmitry Markov wrote:
Thank you for the review, Phil!
I am afraid we cannot create a regression test for this since the issue takes
place only in VNC environment. I have added “noreg-hard” to the bug.
Thanks,
Dmitry
On 19 Sep 2019, at 17:58, Phil Race <[email protected]
<mailto:[email protected]>> wrote:
+1 to the fix but any ideas for a regression test.
There are no related keywords on the bug ..
-phil.
On 9/19/19 9:12 AM, Dmitry Markov wrote:
Hello,
Could you review a fix for jdk14, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8230782
webrev: http://cr.openjdk.java.net/~dmarkov/8230782/webrev.00/
Problem description:
After integration of JDK-8210776 [1] we started to use malloc() function for
allocation of XColor array in QueryColorMap() (see multiVis.c). However
malloc() does not initialise allocated memory. So if the memory contains some
“garbage” we may get incorrect data inside the array. As a result
Robot.createsScreenCapture() retrieves incorrect colours.
Fix:
It is necessary to invoke calloc() for allocation of the array as it used to be
before XWD upgrade
Thanks,
Dmitry
[1] - https://bugs.openjdk.java.net/browse/JDK-8210776
--
Best regards, Sergey.
