On 10/10/19 12:29 am, Hendrik Schreiber wrote:

On Oct 10, 2019, at 03:27, Alan Snyder <javali...@cbfiddle.com> wrote:

I believe your solution works, but shouldn’t you obey 
NSRequiresAquaSystemAppearance = NO if that appears in the Info.plist?

The problem with "NSRequiresAquaSystemAppearance" is that it is ignored for 
non-bundled
applications(if java runs from the command line), and the fix just unify 
solution to
enable/disable modes for bundled and non-bundled apps.
BTW:
"NSRequiresAquaSystemAppearance = NO" means: "build your app against an earlier 
SDK but
still want to support Dark Mode", and I would like to highlight that Dark Mode 
is not supported.
For now there will be no "supported" options to enable it.

Yes, you should, IMHO.

Just to add some info “from the field”:

My Swing-based app uses NSRequiresAquaSystemAppearance = NO in its Info.plist and 
depending on the effective NSApp appearance (read via JNI) either launches the standard 
macOS L&F or the Darcula L&F. In case the system appearance is Dark, titlebars 
are turned dark as well using the client property apple.awt.windowDarkAppearance.

It is possible to do in the current fix but per application appearance,
there was no goal to support per-window appearance and per-window vibrancy.


--
Best regards, Sergey.

Reply via email to