Mario,
Since you pushed this 4 modal dialog automated tests are failing - mostly -
on at least Ubuntu 16.04 and 18.04.
java/awt/Modal/ModalBlockingTests/BlockingWindowsSetModal6Test.java
java/awt/Modal/ModalBlockingTests/BlockingWindowsToolkitModal5Test.java
java/awt/Modal/ModalBlockingTests/BlockingWindowsDocModal2Test.java
java/awt/Modal/ModalBlockingTests/BlockingWindowsToolkitModal6Test.java
They fail in our nightly and I reproduced it locally,
They don't all always fail but never do they all pass : eg
jtreg -a -v
java/awt/Modal/ModalBlockingTests/BlockingWindowsSetModal6Test.java
java/awt/Modal/ModalBlockingTests/BlockingWindowsToolkitModal5Test.java
java/awt/Modal/ModalBlockingTests/BlockingWindowsDocModal2Test.java
java/awt/Modal/ModalBlockingTests/BlockingWindowsToolkitModal6Test.java
runner starting test:
java/awt/Modal/ModalBlockingTests/BlockingWindowsDocModal2Test.java
runner finished test:
java/awt/Modal/ModalBlockingTests/BlockingWindowsDocModal2Test.java
Failed. Execution failed: `main' threw exception:
java.lang.RuntimeException: DummyButton on Frame did not gain focus on
clicking. A document modal dialog and its parent are visible.: expected
true, was false
runner starting test:
java/awt/Modal/ModalBlockingTests/BlockingWindowsSetModal6Test.java
runner finished test:
java/awt/Modal/ModalBlockingTests/BlockingWindowsSetModal6Test.java
Failed. Execution failed: `main' threw exception:
java.lang.RuntimeException: DummyButton on Window did not gain focus on
clicking. The parent of the Window is null Dialog: expected true, was false
runner starting test:
java/awt/Modal/ModalBlockingTests/BlockingWindowsToolkitModal5Test.java
runner finished test:
java/awt/Modal/ModalBlockingTests/BlockingWindowsToolkitModal5Test.java
Failed. Execution failed: `main' threw exception:
java.lang.RuntimeException: DummyButton on Window did not gain focus on
clicking. The parent of the Window is TOOLKIT_MODAL Dialog: expected
true, was false
runner starting test:
java/awt/Modal/ModalBlockingTests/BlockingWindowsToolkitModal6Test.java
runner finished test:
java/awt/Modal/ModalBlockingTests/BlockingWindowsToolkitModal6Test.java
Passed. Execution successful
Test results: passed: 1; failed: 3
When I backout your change, the tests all pass again.
Prasanta also reported that backing out this change fixed them.
These tests aren't what I'd call 100% stable but there is definitely a
new problem here.
Can you check what you see on your end and we'll have to decide if
there's a follow on
fix or a back out whilst we think about it, or whether you believe there
was a latent
test problem ?
-phil.
On 11/12/19 8:58 AM, Mario Torre wrote:
On Mon, 2019-11-11 at 11:45 +0000, Dmitry Markov wrote:
Hi Mario,
The fix looks good to me.
Thanks, I pushed it.
Cheers,
Mario
