Thanks Alexey and Sergey!
When reviewed, please push to jdk/client [1] rather than jdk/jdk.
Ok, I will do that.
Yasumasa
On 2019/11/20 3:03, Alexey Ivanov wrote:
Hi Yasumasa,
Looks good to me. (Not a reviewer though.)
When reviewed, please push to jdk/client [1] rather than jdk/jdk.
I have submitted a follow-up bug JDK-8234398 [2] to get rid of
ID2D1Factory::GetDesktopDpi and dependency on d2d1.dll.
Regards,
Alexey
[1] http://hg.openjdk.java.net/jdk/client
[2] https://bugs.openjdk.java.net/browse/JDK-8234398
On 19/11/2019 01:33, Yasumasa Suenaga wrote:
PING: Could you review it?
JBS: https://bugs.openjdk.java.net/browse/JDK-8233707
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8233707/webrev.00/
I think it is a trivial change.
Yasumasa
On 2019/11/13 10:15, Yasumasa Suenaga wrote:
Hi Alexey,
Thank you for forwarding this RFR to 2d-dev.
I'm waiting for reviewers.
JBS: https://bugs.openjdk.java.net/browse/JDK-8233707
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8233707/webrev.00/
Yasumasa
On 2019/11/13 3:42, Alexey Ivanov wrote:
Hi Yasumasa,
I think this belongs to 2d-dev list.
On 07/11/2019 00:16, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8233707
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8233707/webrev.00/
I tried to build OpenJDK with VS 2019 (16.3.8), but it couldn't as below.
(My laptop sets locale to Japanese, sorry)
```
c:/OpenJDK/jdk/src/java.desktop/windows/native/common/awt/systemscale/systemScale.cpp(96):
error C2220: 次の警告はエラーとして処理されます
c:/OpenJDK/jdk/src/java.desktop/windows/native/common/awt/systemscale/systemScale.cpp(96):
warning C4996: 'ID2D1Factory::GetDesktopDpi': Deprecated. Use
DisplayInformation::LogicalDpi for Windows Store Apps or GetDpiForWindow for
desktop apps.
c:\progra~2\wi3cf2~1\10\include\100183~1.0\um\d2d1.h(3355): note:
'ID2D1Factory::GetDesktopDpi' の宣言を確認してください
```
I could not find out the description for this deprecation in MSDN.
However, in case of Windows Terminal, this warning avoids with #pragma. So I
think we can fix it in same way.
https://github.com/microsoft/terminal/blob/9dc922fc37a479dd560675ac4ea1ce3713ae0ada/src/renderer/wddmcon/main.cxx#L447
Thanks,
Yasumasa
