Hi Sergey,
The changes look fine to me.
I have a couple of questions though.
awt_Choice.cpp
233 int borderHeight = ScaleDownY(::GetSystemMetrics(SM_CYBORDER));
Documentation says GetSystemMetrics always returns the value for the
primary monitor. Shall we still scale the value down? Or it will be
compensated by the following ScaleUpY in ResetDropDownHeight?
In test, you can extend the existing try-block instead of creating a new
one.
Can also correct the typo in the bug summary: “faild” → “failed”?
Regards,
Alexey
On 03/02/2020 12:25, Jayathirth D v wrote:
Changes are fine.
Thanks,
Jay
On 03-Feb-2020, at 12:49 PM, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote:
Hello.
Please review the fix for jdk/client.
Bug: https://bugs.openjdk.java.net/browse/JDK-8225126
Fix: http://cr.openjdk.java.net/~serb/8225126/webrev.00
One more fix for the bug where we inconsistently mix the user's
space coordinates and device's space coordinates and provoke an
infinite repainting loop.
In the fix, all values from the native API like
GetSystemMetrics/GetWindowRect should be converted to the user's
space, and data passed to the native API should be converted to
device space.
The test SetBoundsPaintTest.java is moved from the closed to the
open repo.
--
Best regards, Sergey.
