Looks good.

On 13/02/2020 06:43, Sergey Bylokhov wrote:
Hi, Alexey.

The summary updated as suggested:
http://cr.openjdk.java.net/~serb/8238741/webrev.01

On 2/12/20 8:54 am, Alexey Ivanov wrote:
Hi Sergey,

Looks good.

Yet the summary in the test seems confusing:
32  * @summary Check that Robot constructors do not throw unexpected exceptions in
33  *          headless mode
The test checks that the *expected* AWTException is thrown.

Shall the summary be: “Check that Robot contructors throw AWTException in headless environment”?

On 10/02/2020 08:52, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk/client.

Bug: https://bugs.openjdk.java.net/browse/JDK-8238741
Fix: http://cr.openjdk.java.net/~serb/8238741/webrev.00

The check for the "headless state" was extracted from the
first constructor to the separate method which now called
by both constructors.

--
Regards,
Alexey

Reply via email to