Looks fine.
On 2/27/20 3:46 am, Pankaj Bansal wrote:
Hi Sergey,
Thanks for the review.
<< Please remove the text and code about MToolkit, this toolkit was deleted in
jdk7.
Done.
webrev: http://cr.openjdk.java.net/~pbansal/8204161/webrev01/
Regards,
Pankaj
-----Original Message-----
From: Sergey Bylokhov
Sent: Thursday, February 27, 2020 4:28 PM
To: Pankaj Bansal <pankaj.b.ban...@oracle.com>; awt-dev@openjdk.java.net
Subject: Re: <AWT Dev> [15] RFR JDK-8204161: Testcase auto failed with the "Applet
thread threw exception: java.lang.UnsupportedOperationException" exception.
Hi, Pankaj.
Please remove the text and code about MToolkit, this toolkit was deleted in
jdk7.
On 2/26/20 11:22 pm, Pankaj Bansal wrote:
Hi All,
Please review the following test only fix for jdk15.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8204161
webrev:
http://cr.openjdk.java.net/~pbansal/8204161/webrev00/
Issue:
The testcases fail with exception Applet thread threw exception:
java.lang.UnsupportedOperationException" exception on Ubuntu 18.04.
Cause:
The test cases are failing as Ubuntu 18.04 does not support SystemTray and the
tests are lacking proper checks for the same. So, the tests tries to use
SystemTray and throw this exception.
Fix:
AddPopupAfterShowTest: This test already has a check for SystemTray support
and returns from Applet init function, but the Applet start function does not
have this check and tries to use SystemTray. The test should just exit after
first check if the SystemTray is not supported. Also, I have removed the Applet
use in the test.
MiddleButtonEventTest: This test is missing the check for SystemTray
altogether. Added the check for same and removed the Applet use from the test.
The test is moved from the closed repo to open repo, so looks like a new test
in webrev.
The tests pass in Windows, Linux and Mac.
Regards,
Pankaj Bansal
--
Best regards, Sergey.
