Looks fine, I assume that you checked the build using VS 2017 as well.
On 3/17/20 4:48 am, Yasumasa Suenaga wrote:
Hi all, Please review this change: JBS: https://bugs.openjdk.java.net/browse/JDK-8241087 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8241087/webrev.00/ I tried to build OpenJDK with VS 2019 (version 16.5.0), but it failed due to C2039 and C2873. alloc.h defines malloc / calloc / realloc to undeclared value not for using them. They seem to affect to C++ runtime internal call (in cstdlib). Please see error message from cl.exe on JBS. Thanks, Yasumasa
-- Best regards, Sergey.