On 6/17/20 5:50 pm, Sergey Bylokhov wrote:

I guess it is too early to compare behavior before and after the fix since the 
fix has a few bugs.
  - It does not fetch several sizes, as it was expected from the code, but load 
only one native size
and map it to the different resolutions.
  - It reverts part of the JDK-8151385, and as far as I understand the bug 
described in
    8151385 starts to reproduce.

BTW I think the best possible fix is to load all actually existed icons into 
the MRI:
  - The user will be able to use any of these icons via 
MRI.getResolutionVariants()
  - And it solves all problems related to HiDPI.
But the open question is it possible to "load all actually existed icons" or 
not.

And if that's not possible then we need to investigate different possible 
approaches.
 - Returning exact icon as the user requested
 - Returning some predefined array of icons
 - Returning some predefined MRI.
 - Load all the icons at once
 - Load icons on the fly when the rendering are occurring
etc.

--
Best regards, Sergey.

Reply via email to