On Mon, 7 Sep 2020 04:17:39 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> You say you need to use NSDistributedNotificationCenter but you don't. So I >> am confused. > > The problem of crash is about not having proper observer. As per > https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Notifications/Articles/NotificationCenters.html > NSNotificationCenter delivers notifications to observers synchronously > whereas NSDistributedNotificationCenter > notification is usually delivered to the main thread’s run loop, thus not > depending on observer setup. Both will work > but since we use NSNotificationCenter in mac so far, it seems prudent to use > the same methodology for this case too, so > I have rectified the observer setup. Hi Phil, Is there any more feedback on this PR? If not, can you please approve. ------------- PR: https://git.openjdk.java.net/jdk/pull/28
