Hi Conor,
Overall I think this is OK. A few comments to consider:
Have you created a CSR for this change yet? If not you will need one.
The description for almost all of the constructors indicate:
————
Constructor for subclasses to call
——————
Is the above wording used elsewhere in the JDK? Not sure I like it, I might
suggest a little wordsmithing
For example AbstractList uses:
—————
Sole constructor. (For invocation by subclass constructors, typically implicit.)
--------------
For ImageFilter (as an example):
———
Creates an {@code ImageFilter}
--------
I would probably tweak it to something similar to:
————
HashTable: Constructs a new, empty hashtable
FileSystem: Initializes a new instance of this class.
—————
I would suggest including “new” in your proposed wording at a minimum
Best
Lance
> On Aug 17, 2020, at 6:11 AM, Conor Cleary <conor.cle...@oracle.com> wrote:
>
> Hi all,
>
> Looking for reviewers for JDK-8250855, 'Address reliance on default
> constructors in the Java 2D APIs'.
>
> This patch addresses the reliance on default constructors in the following
> packages:
>
> * java.awt.Image
> * java.awt.PrintJob
> * java.awt.font.GlyphVector
> * java.awt.font.LayoutPath
> * java.awt.font.LineMetrics
> * java.awt.image.AbstractMultiResolutionImage
> * java.awt.image.BufferStrategy
> * java.awt.image.ImageFilter
> * java.awt.image.RGBImageFilter
> * java.awt.image.VolatileImage
> * javax.print.PrintServiceLookup
> * javax.print.ServiceUI
> * javax.print.ServiceUIFactory
> * javax.print.StreamPrintServiceFactory
> * javax.print.event.PrintJobAdapter
>
> The patch places simple constructors in all of these packages.
>
> * bug: https://bugs.openjdk.java.net/browse/JDK-8250855
> * webrev:
>
> http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250855/webrevs/webrev.00/
>
>
> Conor
>
Best
Lance
------------------
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
