On Wed, 14 Oct 2020 18:26:35 GMT, Bob Vandette <b...@openjdk.org> wrote:
>> It is generally not expected for such a proposed change to pop up out of >> nowhere from someone who is a new contributor >> without prior discussion and so forth. >> I have no idea where this change is coming from, why we would want it, and >> how it is expected to be supported and you >> have provided zero explanation of any of it in the PR. I think you need to >> start by explaining the big picture, and >> what you expect to do with this and how you are guaranteeing to support it >> and ensure it breaks NOTHING else. At all. >> And then we could also use some technical details on what you perceive is >> needed and why this resolives it. >> Also is this "everything" ? > >> It is generally not expected for such a proposed change to pop up out of >> nowhere from someone who is a new contributor >> without prior discussion and so forth. >> I have no idea where this change is coming from, why we would want it, and >> how it is expected to be supported and you >> have provided zero explanation of any of it in the PR. I think you need to >> start by explaining the big picture, and >> what you expect to do with this and how you are guaranteeing to support it >> and ensure it breaks NOTHING else. At all. >> And then we could also use some technical details on what you perceive is >> needed and why this resolives it. >> Also is this "everything" ? > > I've been coaching @arodionov through this change. This fix extends the work > I did to allow a Java program to be > created using all static libraries. This PR fixes issues where there are > multiply defined symbols in libawt, the > headless and xawt toolkits when linked into a single executable. It also > solves the problem where dlsym doesn't work > for non shared libraries. Sorry I am not familiar with that work. Please provide more info. ------------- PR: https://git.openjdk.java.net/jdk/pull/562
