On Thu, 5 Nov 2020 01:44:30 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Jayashree S Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code Review: Improved comment
>
> src/java.desktop/unix/native/libawt_xawt/awt/swing_GTKEngine.c line 353:
>
>> 351: JNIEnv *env, jobject this)
>> 352: {
>> 353: // Note that gtk->flush_event_loop takes care of locks (7053002)
>
> Different people used these methods (gdk_threads_enter/gdk_threads_leave)
> here twice which caused two regressions. Looks like the comment about locks
> is not enough. Could you please update the comment and state that
> gdk_threads_enter/gdk_threads_leave must not be used here?
@mrserb: I have addressed the review comment. Thanks!
-------------
PR: https://git.openjdk.java.net/jdk/pull/932
