On Thu, 10 Dec 2020 08:56:43 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> This defines some macros to support declaring and initialising statically >> allocated instances of jclass, jmethodID and jfieldID >> and changes many existing uses of JNF macros/functions to use these instead. >> Then calls to JNFCall* and JNFNewObject - etc are updated to directly call >> JNI methods >> JNI exception checking macros are added as needed. > > Wouldn't it have been nice to have a new file having same JNF macros so it > will not result in changing any source code but just instead of mapping to > apple provided JNF layer, we will map to our macro through JNF wrapper and > link/unlink apple JNF lib based on version or so in makefile? This siunds good, especially considering JEP-391, where we have to link ( at build time) with custom made JNF.framework and then provide jdk with JNF.framework in JAVA_HOME/lib The alternative is to integrate JNF (bsd3 license) into openjdk. ------------- PR: https://git.openjdk.java.net/jdk/pull/1679
