On Tue, 15 Dec 2020 20:58:44 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> Andrii Rodionov has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains one commit:
>> 
>>   8254024: Enhance native libs for AWT and Swing to work with GraalVM Native 
>> Image
>
> This makes sense from a build PoV, but you'll need approval from the client 
> team as well.

> @prrace It may be also useful to look at how we define a set of static 
> libraries:
> https://github.com/oracle/graal/blob/9390324021ab7b6ed391f2c8f62be490a7ab13db/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/jdk/JNIRegistrationAwt.java#L104

If by "help" you mean scare the life out of me ..
I am sure I don't understand all of it but enough to know  I've never seen so 
many references to JDK internals and behaviours
by some code that is not part of the JDK itself.
It seems very fragile to the point of not being supportable.

If someone else wants to approve this change they can, but my conscience isn't 
letting me ..

-------------

PR: https://git.openjdk.java.net/jdk/pull/562

Reply via email to