On Thu, 21 Jan 2021 10:49:44 GMT, Pankaj Bansal <pban...@openjdk.org> wrote:

>> Create implementation for NSAccessibilityStaticText protocol
>> 
>> For testing that Label accessibility works fine, I have used something like 
>> https://docs.oracle.com/javase/tutorial/uiswing/examples/components/LabelDemoProject/src/components/LabelDemo.java.
>>  I also tried few other labels with html text. I have verified that the 
>> Voice Over output for JLables is same before and after this change.
>> 
>> The class CommonTextAccessibility has most of the code taken from 
>> JavaTextAccessibility. Only the functions needed for StaticTextAccessibility 
>> have been taken as of now. Few more (not all) functions will be added to 
>> this class from JavaTextAccessiblity when work is done for 
>> NavigableStaticText or TextField, TextArea, Text, Password etc accessibility 
>> roles.
>> 
>> I could not see AccessibleRole.HYPERLINK or "hyperlink" role being used 
>> anywhere. As we are reworking the implementation, I have included both roles 
>> "label" and "hyperlink" as of now.
>
> Pankaj Bansal has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add nullable flag in CommonTextAccessibility function for consistency

Marked as reviewed by kizune (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2147

Reply via email to