On Tue, 13 Apr 2021 09:11:44 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> Test was problemlisted due to it failing repeatedly on macos in automated > nightly testing citing "java.awt.IllegalComponentStateException: component > must be showing on the screen to determine its location " > Added delay after the setVisible() is called to make sure enough time is > given for frame to be visible, which is in sync with what we do for similar > other tests. > Also, made the frame to center of screen and increase the autoDelay time to > 100ms which is also same as done in similar to other tests. > Several iterations of the test works fine in all platforms after this > modification. I am not 100% sure about adding additional 1000ms delay after creating GUI. Since it is mentioned as common approach(may be because of slow CI systems), change looks good to me. test/jdk/java/awt/Mouse/MouseComboBoxTest/MouseComboBoxTest.java line 2: > 1: /* > 2: * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. We should keep both initial year of addition and latest updated year. Please update it before pushing. ------------- Marked as reviewed by jdv (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3456
