On Thu, 22 Apr 2021 13:05:09 GMT, Pankaj Bansal <pban...@openjdk.org> wrote:
> The tests java/awt/Focus/8073453/AWTFocusTransitionTest.java and > java/awt/Focus/8073453/SwingFocusTransitionTest.java fail on MacOS > intermittently and are problem listed. The test needs lot of Robot actions. > It does not test if the components are visible on the screen. > > The changes fix this issue. Also, the frame is moved to centre of screen and > set to be at top always. Some more cleanup is done. The test is passing for > multiple iterations on all platforms on CI. Link in JBS. test/jdk/java/awt/Focus/8073453/AWTFocusTransitionTest.java line 74: > 72: robot.waitForIdle(); > 73: > 74: blockTillDisplayed(textField); Are you sure that this block is needed? How it is possible that the component which was made visible above in the createAndShowGUI() may be invisible here? test/jdk/java/awt/Focus/8073453/SwingFocusTransitionTest.java line 138: > 136: > 137: frame.add(p); > 138: frame.setAlwaysOnTop(true); setAlwaysOnTop() will make a different type of windows and it may affect the test, please make sure that both related bugs could be verified by these updated tests. ------------- PR: https://git.openjdk.java.net/jdk/pull/3624
