On Thu, 20 May 2021 18:49:53 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 27:
>> 
>>> 25:  * @test
>>> 26:  * @bug 8182043
>>> 27:  * @requires os.family == "windows"
>> 
>> Other than using "explorer" what prevents us to run this test on other 
>> platforms?
>
>> Other than using "explorer" what prevents us to run this test on other 
>> platforms?
> 
> Because right now it makes no sense? The functionality we are testing is 
> implemented on Windows only. Once we extend it to other platforms we might 
> change the test.

But this is shared code, which has a specification it should work everywhere, 
so even if on Linux and macOS it is not implemented in the best way it should 
return something.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2875

Reply via email to