On Tue, 25 May 2021 05:38:19 GMT, Pankaj Bansal <pban...@openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed old style nullability attributes in StaticTextAccessibility.h > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CheckboxAccessibility.h > line 32: > >> 30: }; >> 31: - (NSAccessibilityRole _Nonnull)accessibilityRole; >> 32: - (id _Nonnull)accessibilityValue; > > Looks like the value can be null. No? Not here. The value here is a state of the checkbox - checked or not checked, unlike text components where value can be set to null, here value is being generated from the component state and can not be null. > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.h > line 32: > >> 30: }; >> 31: - (NSAccessibilityRole _Nonnull)accessibilityRole; >> 32: - (id _Nonnull)accessibilityValue; > > Same as earlier. Can't this be null? Same here, value represents the state of the control and can not be set to null. > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/StaticTextAccessibility.h > line 39: > >> 37: - (NSAccessibilityRole _Nonnull)accessibilityRole; >> 38: - (nullable NSString >> *)accessibilityAttributedStringForRange:(NSRange)range; >> 39: - (nullable NSString *)accessibilityValue; > > You missed these here in .h file Yes. Fixed. ------------- PR: https://git.openjdk.java.net/jdk/pull/4162
