Thanks for your remarks, Paul. It will help me to build more suitable kernel patchs next time (soon :-) ).
Pierre Paul Sokolovsky a écrit : > Hello Pierre, > > Thursday, February 8, 2007, 10:50:59 PM, you wrote: > > >> Hi, >> > > >> this patch includes support for Axim X50 buttons, aximx50-gpio.h clean >> up and Kconfig code to manage X50/X51(v) variants. >> It applies on HEAD HH kernel. >> > > Thanks for your patches! Few comments: > > 1. Could you use real tabs for indents? That's standard kernel style. > Setting editor to display tabs at standard 8 space width may help - > there're few indenting inconsistences if patches submitted by you. > > 2. We have common button keycode map to use, defined in input_pda.h. > Archives contain extensive discussion why is it needed, one important > point is that it is common, so any device using it will work out of > the box of with minimal changes with current version of GPE/OPIE. So, > I've changed it. KEY_WLAN is left as is ;-). > > 3. Feel free to prune copyright/author list if it makes sense. As > aximx50_buttons.c is essentially shim driver on top of > pxa27x-keyboard, and noone but yourself work on it, I left only you > there. > > 4. I'd recommend against just killing printks/SET_GPIO from UDC > handlers. Let them better print stuff and remind that it is important > to implement them ;-). Otherwise, it's easy to forget about that. > > 5. All that SUBARCH_X50/SUBARCH_X51 is a bit too magic. I didn't apply > it because SUBARCH_X51 wasn't really defined ;-). But may I suggest > skipping such approach at all? Ideally, detection should happen at > runtime, but before that, could you consider using CONFIG names which > would show real functionality behind them. For example, if it is (now) > used to select QVGA vs VGA modes, it's worth call it like > AXIMX50_LCD_VGA. Thinking in such way is really helpful for > maintaining integrity of port (vs letting it drop by pieces of > separate vendor models) ;-) > > > Otherwise, committed and tested to build. > > >> Your remarks are welcome. >> > > >> Pierre >> > > > > >
-- _______________________________________________ Aximx50-port mailing list [email protected] https://www.handhelds.org/mailman/listinfo/aximx50-port
