Hi everybody, recently I have done some research on how SOAP Faults are generated. I meet the following issue you can find here: https://issues.apache.org/jira/browse/AXIS2-4216 It is about the creation of the SOAP Fault. If you look at this it will become obvious that SOAPFaultCode and SOAPFaultSubCode implementation can be refactored. My proposal is that both they can extend a common interface and thus make them more natural and reusable. No need of casting anymore.
The fixes are applied to the current mail. Looking forward for your comments on this. thank you in advance, Dobri
/* * Created at 27.01.2009 by Dobri Kitipov (bgdki). Mail: <[email protected]></a> * * Copyright 2009 by Software AG * * Uhlandstrasse 12, D-64297 Darmstadt, GERMANY * * All rights reserved * * This software is the confidential and proprietary * information of Software AG ('Confidential Information'). * You shall not disclose such Confidential Information and * shall use it only in accordance with the terms of the license * agreement you entered into with Software AG or its distributors. */ package org.apache.axiom.soap; import org.apache.axiom.om.OMElement; /** * SOAPBaseFault.java * * Created at 27.01.2009 by Dobri Kitipov (bgdki). Mail: <[email protected]></a> * * Copyright (C) 2009 SOFTWARE AG, Germany. All Rights Reserved. */ public interface SOAPBaseFault extends OMElement { /** * Fault SubCode contain only one mandatory Value child. This value child contains a QName * * @param soapFaultSubCodeValue */ void setValue(SOAPFaultValue value) throws SOAPProcessingException; /** @return Returns SOAPFaultValue. */ SOAPFaultValue getValue(); /** * Fault SubCode can contain an optional SubCode * * @param subCode */ void setSubCode(SOAPFaultSubCode value) throws SOAPProcessingException; /** @return Returns SOAPFaultSubCode. */ SOAPFaultSubCode getSubCode(); }
SOAPFaultCode_patch.patch
Description: Binary data
SOAPFaultSubCode_patch.patch
Description: Binary data
_______________________________________________ Axiom-developer mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/axiom-developer
