For the moment I will revert back this change. I will write later in detail. sorry about breaking your test runs.
sanjaya. ----- Original Message ----- From: "Adrian Dick" <[EMAIL PROTECTED]> To: <[email protected]> Sent: Wednesday, March 23, 2005 11:37 PM Subject: Re: cvs commit: ws-axis/c/build testInitialize.xml > Hi, > > This fix is not suitable, and indeed breaks completely for our automated > test systems here. > We carry out all our testing as a customer would be expected, having access > to just the binary package. Unfortunately, this means the files you're > attempting to work with do not exist, causing ANT to fail. > > There are several issues that come to mind as I look at this particular > fix: > - Why are we renaming built libraries? > Either the test needs to cope with what it's given, or there's a > problem in the build and package steps. > In this particular case, the test script needs to determine which of > the XML parsers it wishes to test with, and use directly: > - Why are we working with files in obj/bin? > Surely we should be testing against the packaged (obj/package/....) > structure, as we provide to our customers? > > > I have added failonerror="false" to the copy task, which prevents ANT from > failing. I also needed to replicate a number of new properties you've > recently added to build.linux.properties across to the properties files for > the other platforms. > > However, I am still not happy with this being done. I would much prefer > that we set a property for the desired xmlparser library name ... perhaps > overriding ${xmlParserLibraryName} with the appropriate choice of > ${xml4c.xmlParserLibraryName} or ${xerces.xmlParserLibraryName}, where the > copy is currently taking place. > > Regards, > Adrian > _______________________________________ > Adrian Dick ([EMAIL PROTECTED]) > WebSphere MQ and ESB Development > Tel: +44-(0)-1962-819212 > Notes: Adrian Dick/UK/[EMAIL PROTECTED] > > [EMAIL PROTECTED] wrote on 23/03/2005 09:31:30: > > > sanjaya 2005/03/23 01:31:30 > > > > Modified: c/build testInitialize.xml > > Log: > > added changes to copy parser specific library to generic parser > > library name in ${dir.bin} > > > > Revision Changes Path > > 1.3 +13 -1 ws-axis/c/build/testInitialize.xml > > > > Index: testInitialize.xml > > =================================================================== > > RCS file: /home/cvs/ws-axis/c/build/testInitialize.xml,v > > retrieving revision 1.2 > > retrieving revision 1.3 > > diff -u -r1.2 -r1.3 > > --- testInitialize.xml 8 Feb 2005 15:24:19 -0000 1.2 > > +++ testInitialize.xml 23 Mar 2005 09:31:30 -0000 1.3 > > @@ -16,7 +16,19 @@ > > <isset property="windows"/> > > </not> > > </condition> > > - </target> > > + > > + <!-- set the built lib for the selected client partser --> > > + <condition property="selectedClientParserLib" > > value="${libraryPrefix}${xml4c.xmlParserLibraryName}${librarySuffix}"> > > + <istrue value="${testconf.client.parser.xml4c}"/> > > + </condition> > > + <condition property="selectedClientParserLib" > > value="${libraryPrefix}${xerces.xmlParserLibraryName}${librarySuffix}"> > > + <istrue value="${testconf.client.parser.xerces}"/> > > + </condition> > > + <!-- make a copy of the parser specfic library with the > > general parser library name --> > > + <copy file="${dir.bin}/${selectedClientParserLib}" > > > tofile="${dir.bin}/${libraryPrefix}${xmlParserLibraryName}${librarySuffix}"/ > > > > + > > +</target> > > + > > > > <target name="initializeLogFile"> > > <mkdir dir="${dir.results}"/> > > > > > > > >
