Hi Devs,
We have the following warnings in our current code base.
I will try to fix as much as possible. Please help if you have some
time to spare.
Thanks,
Samisa...
stream.c: In function 'axis2_stream_create_socket':
stream.c:549: warning: implicit declaration of function 'fdopen'
stream.c:549: warning: assignment makes pointer from integer without a cast
dir_handler.c: In function 'axis2_dir_handler_list_dir':
dir_handler.c:44: warning: implicit declaration of function 'scandir'
In file included from om_document.c:19:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from om_node.c:24:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
om_node.c: In function 'axis2_om_node_build_next':
om_node.c:757: warning: suggest parentheses around assignment used as
truth value
om_node.c:773:29: warning: no newline at end of file
om_node.c:759: warning: control reaches end of non-void function
In file included from om_stax_builder.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
soap_envelope.c: In function 'axis2_soap_envelope_create_null':
soap_envelope.c:109: warning: unused variable 'ele'
In file included from ../../../include/axis2_desc_builder.h:34,
from ../../../include/axis2_conf_builder.h:31,
from ../../../include/axis2_dep_engine.h:32,
from conf.c:21:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
engine.c: In function 'axis2_engine_send':
engine.c:214: warning: unused variable 'transport_sender'
engine.c: In function 'axis2_engine_send_fault':
engine.c:346: warning: unused variable 'transport_sender'
In file included from ../../../../include/axis2_http_transport_utils.h:29,
from axis2_http_worker.c:25:
../../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../../include/axis2_http_transport_utils.h:29,
from axis2_http_transport_utils.c:17:
../../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../include/axis2_desc_builder.h:34,
from desc_builder.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../include/axis2_desc_builder.h:34,
from ../../../include/axis2_conf_builder.h:31,
from ../../../include/axis2_dep_engine.h:32,
from ../../../include/axis2_arch_reader.h:34,
from arch_reader.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../include/axis2_desc_builder.h:34,
from ../../../include/axis2_conf_builder.h:31,
from ../../../include/axis2_dep_engine.h:32,
from dep_engine.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../include/axis2_desc_builder.h:34,
from ../../../include/axis2_conf_builder.h:31,
from ../../../include/axis2_dep_engine.h:32,
from ../../../include/axis2_ws_info_list.h:37,
from ws_info_list.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../include/axis2_desc_builder.h:34,
from ../../../include/axis2_svc_builder.h:31,
from svc_builder.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../include/axis2_desc_builder.h:34,
from ../../../include/axis2_svc_grp_builder.h:31,
from svc_grp_builder.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../include/axis2_desc_builder.h:34,
from ../../../include/axis2_conf_builder.h:31,
from ../../../include/axis2_dep_engine.h:32,
from ../../../include/axis2_module_builder.h:32,
from module_builder.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../include/axis2_repos_listener.h:32,
from ../../../include/axis2_dep_engine.h:33,
from ../../../include/axis2_desc_builder.h:32,
from ../../../include/axis2_conf_builder.h:31,
from conf_builder.c:17:
../../../include/axis2_ws_info_list.h:164: warning: 'struct
axis2_dep_engine' declared inside parameter list
../../../include/axis2_ws_info_list.h:164: warning: its scope is only
this definition or declaration, which is probably not what you want
In file included from ../../../include/axis2_desc_builder.h:34,
from ../../../include/axis2_conf_builder.h:31,
from conf_builder.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
In file included from ../../../include/axis2_desc_builder.h:34,
from ../../../include/axis2_conf_builder.h:31,
from ../../../include/axis2_dep_engine.h:32,
from ../../../include/axis2_ws_info_list.h:37,
from ../../../include/axis2_repos_listener.h:32,
from repos_listener.c:17:
../../../include/axis2_om_stax_builder.h:43: warning: useless storage
class specifier in empty declaration
mep_client.c: In function 'axis2_mep_client_prepare_soap_envelope':
mep_client.c:218: warning: implicit declaration of function
'AXIS2_SOAP_BODY_GET_BASE'
mep_client.c:218: warning: assignment makes pointer from integer without
a cast
call.c: In function 'axis2_call_invoke_blocking':
call.c:367: warning: implicit declaration of function
'AXIS2_SOAP_BODY_GET_HAS_FAULT'
call.c: In function 'axis2_call_invoke_blocking_with_om':
call.c:793: warning: implicit declaration of function
'AXIS2_SOAP_BODY_GET_BASE'
call.c:793: warning: assignment makes pointer from integer without a cast
Samisa Abeysinghe wrote:
Hi All,
We have reached the final stage of the basic SOAP engine
implementation. Given the amount of LOC we have by now, it looks to me
that it would be useful to spend some effort to eliminate the compiler
warnings. I would like to propose that we should be having zero
warnings in the next milestone release.
As we make heavy use of macros, sometimes warnings are really
errors, hence it would help us a great deal to have no warnings to
ensure that our source is correct. Please also try to eliminate all
those trivial warning as well, because when they are mixed up with
those critical ones, it becomes hard to work comprehend the compiler
messages.
I think it would be fair enough to say that before committing code
to svn, the committor have to ensure that there are no compiler
warnings. This makes the job easier.
Thanks,
Samisa...
