Hi Dinesh,
IMHO, Guthtila code should be re-organized in line with the changes taken place over the past few months in the main Axis2/C codebase.
   We have improved the logging and error handling mechanisms.
We also have a well tested hash map and array list structures that could be used by Guththila. Please have a look into the source of the util module to get a gauge on the improvements.

Thanks,
Samisa...


-------- Original Message --------
Subject: svn commit: r393763 - /webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c
Date:   Thu, 13 Apr 2006 08:46:21 -0000
From:   [EMAIL PROTECTED]
To:     [EMAIL PROTECTED]



Author: dinesh
Date: Thu Apr 13 01:46:19 2006
New Revision: 393763

URL: http://svn.apache.org/viewcvs?rev=393763&view=rev
Log:
guththila_stack_free () tends to memory leaks when there are no elements

Modified:
   
webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c

Modified: 
webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c
URL: 
http://svn.apache.org/viewcvs/webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c?rev=393763&r1=393762&r2=393763&view=diff
==============================================================================
--- 
webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c
 (original)
+++ 
webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c
 Thu Apr 13 01:46:19 2006
@@ -91,11 +91,13 @@
                      guththila_stack_t * stack)
{
    if (stack && (stack->pointer > 0))
-    {
+      {
        guththila_element_t *ele = stack->tail;
        guththila_stack_free_rec (environment, stack, ele);
        GUTHTHILA_FREE (environment->allocator, stack);
    }
+    else
+      GUTHTHILA_FREE (environment->allocator, stack);
}






Reply via email to