lock() / unlock() mismatch in engine/HandlerLoader.cpp
------------------------------------------------------

         Key: AXISCPP-979
         URL: http://issues.apache.org/jira/browse/AXISCPP-979
     Project: Axis-C++
        Type: Bug

  Components: Server - Engine  
    Versions: current (nightly)    
    Reporter: Henrik Nordberg
    Priority: Minor


In

int HandlerLoader::createHandler (BasicHandler** pHandler, int nLibId)

there is this code:

    //lock ();
 Lock l(this);

and later this code:

    unlock ();

I assume the unlock() call should be commented out, as this is the case in 
other places. ~Lock() releases the mutex it acquired in Lock() so an explicit 
call to l.unlock() (as in other places in that file) should not be needed.

Also, as a side note, it would be better to use critical sections on Windows, 
since mutexes on that platform are cross process and slow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to