As long as the test buckets works we're good to go :-)
| Nadir Amra <[EMAIL PROTECTED]>
21/07/2006 05:10
|
|
I have changed and committed code so that one can tell whether to generate
a TypeMap entry by simply calling method isExternalized(). Basically by
default all types that are not anonymous types are externalized. To
externalize anonymous types another method is called. So there is no
place in the code where it looks for '>' in an object of class Type.
I have run the test buckets and things look good. One thing though. In
AllParamWriter.writeSource(), as it iterates through the TypeMap, the code
is as follows:
type = (Type) types.next();
if (type.isArray())
{ ... }
else if (type.isAnonymous() && !type.isExternalized())
{
if(WSDL2Ws.verbose)
System.out.println("ignoring anonymous type " +
type.getLanguageSpecificName() + "\n");
}
else
{
if (WSDL2Ws.verbose)
System.out.println("struct writer called
for......" + type.getName());
(new BeanParamWriter(wscontext, type)).writeSource();
(new ParmHeaderFileWriter(wscontext,
type)).writeSource();
}
I see no reason why I should not change the logic to:
if (!type.isExternalized())
{
if(WSDL2Ws.verbose)
System.out.println("ignoring anonymous type " +
type.getLanguageSpecificName() + "\n");
}
else if (type.isArray())
{ ... }
else
{
if (WSDL2Ws.verbose)
System.out.println("struct writer called
for......" + type.getName());
(new BeanParamWriter(wscontext, type)).writeSource();
(new ParmHeaderFileWriter(wscontext,
type)).writeSource();
}
And in fact I have changed it in code that I have and ran the test bucket
with no problems. I just want to make sure I am not missing something
before I commit it.
Nadir K. Amra
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
